Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Agent and host Rolling CI (backport #486) #488

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Fix Agent and host Rolling CI (backport #486) #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b8df6a
Fix Agent and host Rolling CI (#486)
pablogs9 Mar 30, 2022
89b0145
Fix
pablogs9 Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
apt install -y python3-colcon-metadata python3-pip
rosdep update --rosdistro $ROS_DISTRO
rosdep install -y --from-paths src --ignore-src -y
apt install -y ros-${ROS_DISTRO}-rmw-fastrtps-cpp

- uses: actions/download-artifact@v1
with:
Expand Down Expand Up @@ -193,6 +194,7 @@ jobs:
- name: Dependencies
run: |
apt update
apt upgrade -y
# Workaround. Remove when https://discourse.ros.org/t/preparing-for-rolling-sync-delayed-by-python-3-10-transition/24521 solved
apt install -y python3.9-dev
# Install last version of CMake
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,12 @@ jobs:
- name: dependencies
run: |
apt update
# Workaround. Remove when https://discourse.ros.org/t/preparing-for-rolling-sync-delayed-by-python-3-10-transition/24521 solved
apt install -y python3.9-dev
Comment on lines +527 to +528
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Workaround. Remove when https://discourse.ros.org/t/preparing-for-rolling-sync-delayed-by-python-3-10-transition/24521 solved
apt install -y python3.9-dev

Should this be backported?

Copy link
Member

@pablogs9 pablogs9 Mar 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the .yml file that is executed is the one in the default branch aka galactic... So we idk if we are able to have different scripts for each branch.

apt install -y python3-colcon-metadata python3-pip
rosdep update --rosdistro $ROS_DISTRO
rosdep install -y --from-paths src --ignore-src -y
apt install -y ros-${ROS_DISTRO}-rmw-fastrtps-cpp

- uses: actions/download-artifact@v1
with:
Expand Down