Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pointToIndex mutates the coordinates of the provided point #2

Open
bjnsn opened this issue Jan 16, 2020 · 0 comments
Open

pointToIndex mutates the coordinates of the provided point #2

bjnsn opened this issue Jan 16, 2020 · 0 comments

Comments

@bjnsn
Copy link

bjnsn commented Jan 16, 2020

Mutation of the point provided as an argument to pointToIndex causes confusing hard to track bugs. It would be helpful to either document the behavior or make the function pure.

See:
https://github.com/mhyfritz/hilbert-curve/blob/master/src/index.js#L59
https://github.com/mhyfritz/hilbert-curve/blob/master/src/index.js#L69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjnsn