Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pyroscope querier SelectMergeProfile for PGO #525

Closed
Cluas opened this issue Jun 20, 2024 · 0 comments
Closed

Support pyroscope querier SelectMergeProfile for PGO #525

Cluas opened this issue Jun 20, 2024 · 0 comments
Labels
enhancement New feature or request feature request help wanted Extra attention is needed

Comments

@Cluas
Copy link
Contributor

Cluas commented Jun 20, 2024 •
edited

Background: https://grafana.com/blog/2024/03/11/how-to-use-pgo-and-grafana-pyroscope-to-optimize-go-applications/

This article introduces a case of using pyroscope with PGO. Qryn collects profile data, and ideally we can implement /querier.v1.QuerierService/SelectMergeProfile, the interface mentioned in the article that is actually called eventually: https://github.com/grafana/pyroscope/blob/269ea6d5afe4d3bcdc7591b44afc1397715fbf2d/cmd/profilecli/query.go#L145. This way we can provide the same capability as a real pyroscope server.

proto: https://github.com/grafana/pyroscope/blob/main/api/querier/v1/querier.proto#L139
@lmangani lmangani added enhancement New feature or request help wanted Extra attention is needed feature request labels Jun 20, 2024
@akvlad akvlad mentioned this issue Jul 17, 2024
Merged
@Cluas Cluas closed this as completed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmangani @Cluas