Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix lr scheduling #76

Merged
merged 4 commits into from
Sep 9, 2022
Merged

Conversation

XuehaiPan
Copy link
Member

@XuehaiPan XuehaiPan commented Sep 9, 2022

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the code using make lint (required)
  • I have ensured make test pass. (required)

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #76 (9cf678e) into main (d1b1898) will increase coverage by 1.39%.
The diff coverage is 79.16%.

❗ Current head 9cf678e differs from pull request most recent head b12d7de. Consider uploading reports for the commit b12d7de to get more accurate results

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   68.77%   70.16%   +1.39%     
==========================================
  Files          31       31              
  Lines        1393     1391       -2     
==========================================
+ Hits          958      976      +18     
+ Misses        435      415      -20     
Flag Coverage Δ
unittests 70.16% <79.16%> (+1.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/_src/linalg.py 91.54% <0.00%> (ø)
torchopt/_src/utils.py 12.64% <0.00%> (ø)
torchopt/_src/implicit_diff.py 91.87% <66.66%> (ø)
torchopt/_src/alias.py 76.78% <100.00%> (+3.97%) ⬆️
torchopt/_src/schedule.py 80.00% <100.00%> (-0.96%) ⬇️
torchopt/_src/transform.py 80.69% <100.00%> (+4.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@XuehaiPan XuehaiPan merged commit d8f90cc into metaopt:main Sep 9, 2022
@XuehaiPan XuehaiPan deleted the fix-lr-schedule branch September 9, 2022 16:34
XuehaiPan added a commit that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants