Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples of parallel training on one GPU using functorch.vmap with torchopt #32

Merged
merged 12 commits into from
Aug 11, 2022
Merged

Examples of parallel training on one GPU using functorch.vmap with torchopt #32

merged 12 commits into from
Aug 11, 2022

Conversation

Benjamin-eecs
Copy link
Member

@Benjamin-eecs Benjamin-eecs commented Jul 19, 2022 •
edited
Loading

#23

under examples/functorch folder

cc @vmoens @waterhorse1 @zou3519 @Chillee

@XuehaiPan XuehaiPan added enhancement New feature or request functorch Something functorch related labels Jul 20, 2022
@Benjamin-eecs Benjamin-eecs linked an issue Jul 20, 2022 that may be closed by this pull request
[Feature Request] Parallel training using vmap #23
Closed
2 tasks
@Benjamin-eecs Benjamin-eecs marked this pull request as ready for review July 21, 2022 13:11
vmoens
vmoens reviewed Jul 23, 2022
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments here and there :)

examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
@Benjamin-eecs
Copy link
Member Author

Just a couple of comments here and there :)

Also, there is a colab to play with :)

@waterhorse1 waterhorse1 mentioned this pull request Jul 25, 2022
Open
@Benjamin-eecs Benjamin-eecs self-assigned this Jul 25, 2022
@Benjamin-eecs Benjamin-eecs added this to the 0.5.0 milestone Jul 25, 2022
@XuehaiPan XuehaiPan added the example / tutorial Something related to examples or tutorials label Jul 26, 2022
@Benjamin-eecs Benjamin-eecs mentioned this pull request Aug 6, 2022
Open
1 task
XuehaiPan
XuehaiPan requested changes Aug 10, 2022
View reviewed changes
Copy link
Member

@XuehaiPan XuehaiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conversations and add a new line to the changelog.

examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
tests/unit/low_level/test_low_level_inplace.py Outdated Show resolved Hide resolved
torchopt/_src/transform.py Outdated Show resolved Hide resolved
examples/functorch/parallel_train_torchopt.py Outdated Show resolved Hide resolved
Benjamin-eecs and others added 2 commits August 11, 2022 17:09
@Benjamin-eecs @XuehaiPan
fix: update torchopt/_src/transform.py
84615d2 
Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
@Benjamin-eecs @XuehaiPan
fix: update torchopt/_src/transform.py
aa8efd4 
Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
@Benjamin-eecs Benjamin-eecs merged commit ee0e4eb into metaopt:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 left review comments

@XuehaiPan XuehaiPan XuehaiPan approved these changes

@waterhorse1 waterhorse1 Awaiting requested review from waterhorse1

@vmoens vmoens Awaiting requested review from vmoens

Assignees

@Benjamin-eecs Benjamin-eecs

Labels
enhancement New feature or request example / tutorial Something related to examples or tutorials functorch Something functorch related
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Parallel training using vmap
4 participants
@Benjamin-eecs @zou3519 @XuehaiPan @vmoens