Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix transpose empty iterable with zip(*nested) in transformations #145

Merged
merged 10 commits into from
Mar 7, 2023

Conversation

XuehaiPan
Copy link
Member

Description

Describe your changes in detail.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

@XuehaiPan XuehaiPan self-assigned this Mar 3, 2023
@XuehaiPan XuehaiPan added this to the 0.8.0 milestone Mar 3, 2023
@XuehaiPan XuehaiPan linked an issue Mar 3, 2023 that may be closed by this pull request
3 tasks
@XuehaiPan XuehaiPan added bug Something isn't working better errors Need better user-end error messages labels Mar 3, 2023
@XuehaiPan XuehaiPan changed the title fix: fix transpose empty iterable with zip(*nested) fix: fix transpose empty iterable with zip(*nested) in transformations Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.00 🎉

Comparison is base (30db8ec) 91.97% compared to head (de6b176) 92.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   91.97%   92.97%   +1.00%     
==========================================
  Files          66       66              
  Lines        2564     2574      +10     
==========================================
+ Hits         2358     2393      +35     
+ Misses        206      181      -25     
Flag Coverage Δ
unittests 92.97% <100.00%> (+1.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchopt/base.py 83.64% <ø> (-2.73%) ⬇️
torchopt/typing.py 100.00% <ø> (ø)
torchopt/utils.py 86.77% <ø> (ø)
torchopt/diff/implicit/nn/module.py 100.00% <100.00%> (+17.86%) ⬆️
torchopt/diff/zero_order/nn/module.py 100.00% <100.00%> (+8.33%) ⬆️
torchopt/transform/scale_by_adam.py 100.00% <100.00%> (ø)
torchopt/accelerated_op/__init__.py 91.67% <0.00%> (-8.33%) ⬇️
torchopt/nn/module.py 81.36% <0.00%> (+4.09%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@XuehaiPan XuehaiPan force-pushed the empty-transpose branch 2 times, most recently from f945060 to 4357eb3 Compare March 3, 2023 18:22
Copy link
Member

@Benjamin-eecs Benjamin-eecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the refactor, LGTM!

@XuehaiPan XuehaiPan merged commit 181770a into metaopt:main Mar 7, 2023
@XuehaiPan XuehaiPan deleted the empty-transpose branch March 7, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
better errors Need better user-end error messages bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Got empty meta-parameters using ImplicitMetaGradientModule
2 participants