Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(setup): rewrite packaging #24

Merged
merged 23 commits into from
Jul 10, 2022
Merged

chore(setup): rewrite packaging #24

merged 23 commits into from
Jul 10, 2022

Conversation

XuehaiPan
Copy link
Member

@XuehaiPan XuehaiPan commented Jul 7, 2022

Description

  • Rewrite packaging

    1. Totally refactor setup.py and remove function download_shared_lib. We don't need to download the .so files from an arbitrary server because they are included in the wheels (.whl).
    2. Remove git submodule pybind11 and use the PyPI package pybind11 instead. (Required by sdist).

    Now we can build from source by (requires nvcc):

    git clone https://github.com/metaopt/torchopt.git
    cd torchopt
    pip3 install .
  • Update GitHub Action workflows.

    1. Install CUDA Toolkit in GitHub Action workflows. (Required by pip3 install -e .)
    2. Build wheels for Python 3.7, 3.8, 3.9, and 3.10.
  • Misc: reformating files, docs update, and fixing requirements.

- name: mypy
run: |
make mypy

# - name: docstyle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you got time, maybe add the docstyle? (docsting is a mess right now I think)

Copy link
Member Author

@XuehaiPan XuehaiPan Jul 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may open a separate PR for this.

@XuehaiPan XuehaiPan force-pushed the setup branch 4 times, most recently from e137e3d to d1c83b8 Compare July 8, 2022 03:42
@XuehaiPan XuehaiPan force-pushed the setup branch 4 times, most recently from e4fd724 to 82a3a66 Compare July 8, 2022 07:15
CMakeLists.txt Outdated Show resolved Hide resolved
@XuehaiPan XuehaiPan force-pushed the setup branch 8 times, most recently from fc1c898 to dfebe80 Compare July 10, 2022 07:16
@XuehaiPan XuehaiPan merged commit 103ff1a into metaopt:main Jul 10, 2022
@XuehaiPan XuehaiPan deleted the setup branch July 10, 2022 08:43
@XuehaiPan XuehaiPan added the cxx / cuda Something related to the CXX / CUDA extension label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx / cuda Something related to the CXX / CUDA extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants