Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong visibility modifier #113

Merged
merged 2 commits into from
Jun 1, 2024
Merged

fix wrong visibility modifier #113

merged 2 commits into from
Jun 1, 2024

Conversation

zh217
Copy link
Contributor

@zh217 zh217 commented Jun 1, 2024

This fixes the following error when using this crate:

error[E0446]: crate-private type `HmmContext` in public interface
   --> /Users/zh217/.cargo/registry/src/index.crates.io-6f17d22bba15001f/jieba-rs-0.7.0/src/hmm.rs:154:1
    |
59  | pub(crate) struct HmmContext {
    | ---------------------------- `HmmContext` declared as crate-private
...
154 | pub fn cut_internal<'a>(sentence: &'a str, words: &mut Vec<&'a str>, hmm_context: &mut HmmContext) {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ can't leak crate-private type

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (2736f41) to head (a4aee1c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   84.62%   84.62%           
=======================================
  Files           8        8           
  Lines        2036     2036           
=======================================
  Hits         1723     1723           
  Misses        313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@messense messense merged commit 7f3b273 into messense:main Jun 1, 2024
9 checks passed
Copy link

codspeed-hq bot commented Jun 1, 2024

CodSpeed Performance Report

Merging #113 will not alter performance

Comparing zh217:main (a4aee1c) with main (2736f41)

Summary

✅ 10 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants