This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Hello-World MWT & Soak Cluster fixes #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d upstream as mentioned here: pytest-dev/pytest#4606 (comment) Quoted here incase that link breaks in the future: "We have removed item.get_marker, users should use item.get_closest_marker now (it's a long history, this was not an arbitrary change). Indeed I suspect pytest-cov might need to be updated." item.get_marker was removed in this PR pytest-dev/pytest#4564
…d of a local environment-variable.
…h as 'nonessential_tasks' where underscores are not allowed in task names.
takirala
approved these changes
Feb 21, 2019
testing/sdk_dcos.py
Outdated
|
|
||
| def get_metadata(): | ||
| return sdk_cmd.cluster_request('GET', | ||
| 'dcos-metadata/bootstrap-config.json', |
There was a problem hiding this comment.
we already call another endpoint under dcos-metadata in sdk_utils, may be just move this code in to sdk_utils.py? if you think sdk_dcos may grow in future, then keep this 👍
Co-Authored-By: kaiwalyajoshi <kjoshi@mesosphere.com>
…n be used to differentiate the various hello-worlds. ie --service-name='orchestration/hello-world'
kvish
approved these changes
Feb 22, 2019
|
@kaiwalyajoshi the change to Edit: Kai explained offline that the failures in this PR were unrelated to the breakage caused in nightlies. PRs are not tested against Open :-/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few misc fixes for tooling when running on soak and MWT clusters.