Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: allow install_subdir() of missing directories #676

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

dnicolodi
Copy link
Member

Remove the assert that made sure the source path for install_subdir() is an existing directory. Meson warns in this case but allows it. Empty directories for missing source directories are not created in the Python wheel as these are hardly meaningful.

Remove the assert that made sure the source path for install_subdir()
is an existing directory. Meson warns in this case but allows it.
Empty directories for missing source directories are not created in
the Python wheel as these are hardly meaningful.
@dnicolodi
Copy link
Member Author

Replaces #675

@rgommers rgommers added this to the v0.17.0 milestone Oct 15, 2024
@rgommers rgommers added the bug Something isn't working label Oct 15, 2024
Copy link
Contributor

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to do nothing"instead of erroring out, given the discussion in gh-675.

Meson does display a deprecation warning in the build log like:

WARNING: Deprecated features used:
 * 0.60.0: {'install_subdir with empty directory'}

@rgommers rgommers merged commit 391d021 into mesonbuild:main Oct 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants