New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1271 Fix autonumber positioning in sequence diagrams with multiline texts #1335

Merged

knsv merged 1 commit into mermaid-js:develop from GDFaber:bug/1271_fix_autonumber_position_for_multiline_texts

Apr 11, 2020

Member

GDFaber commented Apr 4, 2020

📑 Summary

Set sequence numbers on the correct position if the corresponding text has line breaks.

Resolves #1271

📏 Design Decisions

Added totalOffset to the number text's y position. Added integration test.

📋 Tasks

Make sure you

📖 have read the contribution guidelines
💻 have added unit/e2e tests (if appropriate)
🔖 targeted develop branch


          #1271 Fix autonumber positioning in sequence diagrams with multiline …

fc70a8e

…texts

knsv approved these changes

View reviewed changes

knsv merged commit a4a1984 into mermaid-js:develop

rajasekaran2003 commented May 16, 2020

https://mermaid-js.github.io/mermaid-live-editor/#/edit/eyJjb2RlIjoic2VxdWVuY2VEaWFncmFtXG4gIGF1dG9udW1iZXJcblx0QWxpY2UtPj4rSm9objogSGVsbG8gSm9obiwgaG93IGFyZSB5b3U_XG5cdEFsaWNlLT4-K0pvaG46IEpvaG4sIGNhbjxici8-IHlvdSBoZWFyIG1lP1xuXHRKb2huLS0-Pi1BbGljZTogSGkgQWxpY2UsIEkgY2FuIGhlYXIgeW91IVxuXHRKb2huLS0-Pi1BbGljZTogSSBmZWVsIGdyZWF0IVxuXHRcdFx0XHRcdCIsIm1lcm1haWQiOnsidGhlbWUiOiJkZWZhdWx0In0sInVwZGF0ZUVkaXRvciI6ZmFsc2V9

still a problem on the latest 8.5.0 with chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet