Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix applying default class to flowchart nodes #1274

Merged
merged 3 commits into from
Feb 25, 2020
Merged

Fix applying default class to flowchart nodes #1274

merged 3 commits into from
Feb 25, 2020

Conversation

GDFaber
Copy link
Member

@GDFaber GDFaber commented Feb 24, 2020

📑 Summary

Fixed classDef default to be applied to all nodes which have no other class assigned.

Resolves #684

📏 Design Decisions

Set class to default if there is no other class defined for the node.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

knsv
knsv approved these changes Feb 25, 2020
View reviewed changes
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good function! I can really see it come to good use. Maybe a note in the docs so that people gets to know about it?

@knsv knsv merged commit 8758bd5 into mermaid-js:develop Feb 25, 2020
@GDFaber GDFaber deleted the bug/apply_default_class_to_flowchart_nodes branch February 25, 2020 18:23
@GDFaber
Copy link
Member Author

GDFaber commented Feb 25, 2020

We already have it in the docs, but it was broken :)
https://mermaid-js.github.io/mermaid/#/flowchart?id=default-class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knsv knsv knsv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

classDef default does not apply
2 participants
@GDFaber @knsv