Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hook for black and flake8 #515

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add pre-commit hook for black and flake8 #515

merged 2 commits into from
Sep 25, 2024

Conversation

as51340
Copy link
Collaborator

@as51340 as51340 commented Sep 25, 2024

Description

There was a different black version remote vs. locally. Added pre-commit hook which runs black and flake8 on python folder respecting configuration from pytest.ini

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@as51340 as51340 added the Docs unnecessary Docs unnecessary label Sep 25, 2024
@as51340 as51340 self-assigned this Sep 25, 2024
@as51340 as51340 changed the title Reformat tgn Add pre-commit hook for black and flake8 Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

@Ignition Ignition merged commit 83d411c into main Sep 25, 2024
6 checks passed
@Ignition Ignition deleted the black-tgn branch September 25, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs unnecessary Docs unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants