Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seek for stable #168

Open
PunitLodha opened this issue Apr 11, 2022 · 0 comments
Open

Seek for stable #168

PunitLodha opened this issue Apr 11, 2022 · 0 comments

Comments

@PunitLodha
Copy link

PunitLodha commented Apr 11, 2022 •
edited
Loading

Currently, on stable, seek doesn't work correctly
For seek implementation, https://github.com/meh/rust-ffmpeg/blob/master/src/format/io.rs#L93-L105, stream_len() is being used which is nightly only and 0 is returned in stable.
According to, rust-lang/rust#59359 and rust-lang/rust#58422, stream_len() is a convenience feature added for improved readability, which can be implemented manually by 3 seeks.

On stable, I think it would be better to manually implement using 3 seeks rather than, returning 0 which does not allow for a seek
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PunitLodha