Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

fix: open files via double-click & cli args #619

Merged
merged 2 commits into from
Sep 20, 2018
Merged

Conversation

faselbaum
Copy link
Contributor

Proposed Changes

Short description of the changes:

  • changed the way how file open requests coming from the os layer are handled

Dev Notes

  • this is a hotfix for the distributed executables
  • ignore error message 'use strict' popping up when opening alva from the dev setup. we need to refactor cli arg handling down the road to get rid of this error as it is caused by assuming that the first cli arg represents the file to open. this is only true in some cases.

Linked Issues

Fixes #[Issue]

Copy link
Member

@tilmx tilmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy!

@tilmx tilmx merged commit 6b982e1 into master Sep 20, 2018
@tilmx tilmx deleted the fix/start-with-file branch September 20, 2018 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants