Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

fix(typescript-react-analyzer): analyze number enums correctly #531

Merged
merged 2 commits into from
Jun 7, 2018

Conversation

tilmx
Copy link
Member

@tilmx tilmx commented Jun 6, 2018

Number Enums were parsed as Strings. They are now parsed as numbers via parseInt.
The headline component from the designkit should now have working enums again.

Should be squashed into fix: analyze number enums correctly

@tilmx tilmx changed the title fix: analyze number enums correctly WIP fix: analyze number enums correctly Jun 6, 2018
@tilmx tilmx changed the title WIP fix: analyze number enums correctly fix: analyze number enums correctly Jun 6, 2018
@tilmx tilmx requested a review from lkuechler June 6, 2018 22:51
@lkuechler
Copy link
Member

@tilmx
in your target squash commit you can also add a scope: fix(typescript-react-analyzer): analyze number enums correctly

@tilmx tilmx changed the title fix: analyze number enums correctly fix(typescript-react-analyzer): analyze number enums correctly Jun 7, 2018
@lkuechler lkuechler merged commit 303a69d into master Jun 7, 2018
@lkuechler lkuechler deleted the fix/fix-enums branch June 7, 2018 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants