UglifyJS compressing causes Range Error #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UglifyJS2 with compression enabled and default options will see the line
"" + this.toString()
and minify it into this line
"" + this
and that normally should work, but the .valueOf() function then falls into
an infinite loop. Assigning the same function to both .toString() and
.valueOf() not only eliminates this problem, but it also shrinks the code an
eensy weensy bit.
|
looks good! don't even remember why that used to be two separate functions. |
|
What is the process for getting a pull request merged? Is there a wait time or a review checklist? Mandatory quarantine period? :-) I ask only because I'd love to update the git submodule in my project instead of pointing everyone on the team temporarily to my fork. |
rodneyrehm
added a commit
that referenced
this pull request
Jan 8, 2013
UglifyJS compressing causes Range Error
|
merged and released :) |
|
Fantastic! Thanks for getting that rolled out.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UglifyJS2 with compression enabled and default options will see the line
and minify it into this line
and that normally should work, but the
.valueOf()function then falls intoan infinite loop. Assigning the same function to both
.toString()and.valueOf()not only eliminates this problem, but it also shrinks the code aneensy weensy bit.