Fixed bug whereby absoluteTo failed on a root base #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
giltayar
commented
Mar 24, 2015
giltayar
commented
E.g. URI("tofile").absoluteTo("/file") should return "/tofile" but didn't.
Added test case
| @@ -1863,6 +1863,7 @@ | |||
|
|
|||
| if (resolved.path().charAt(0) !== '/') { | |||
| basedir = base.directory(); | |||
| basedir = basedir ? basedir : base.path().indexOf('/') === 0 ? '/' : ''; | |||
There was a problem hiding this comment.
that reads horribly (not that my code reads any better…)
wondering if the following makes more sense
// either basedir is a thing, or path begins with /, defaults to empty string
basedir || base.path().slice(0, 1) === '/' && '/' || '';There was a problem hiding this comment.
Yes, I know. It somehow seems that there should be a cleaner way to do this... :-) But I couldn't find it (admittedly,
As for changing the ?: to ||&& - that's a question of style. My code is more "say what you mean", yours is more concise. I could go either way.
There was a problem hiding this comment.
yeah… this is personal preference, I agree.
since most of the code is using ternaries rather than "truthy-switches" (whatever they're called), I'd roll with your solution for now.
rodneyrehm
added a commit
that referenced
this pull request
Mar 31, 2015
Fixed bug whereby absoluteTo failed on a root base
|
released v1.15.0, thank you for your support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.