Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyword argument for ERB.new to suppress deprecated warnings #103

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

ykitamura-mdsol
Copy link
Contributor

keyword argument for ERB.new

To suppress these warnings:

warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

voormedia/rails-erd#297

Use default bundle path

In recent versions of Bundler, Bundler.settings[:path] returns nil if you only set BUNDLE_DEPLOYMENT=true so dice_bag is a little too greedy...

File '/home/app/web/config/database.yml' created
:
File '/home/app/web/vendor/bundle/ruby/3.0.0/gems/dice_bag-1.6.0/lib/dice_bag/templates/databases/mysql.yml' created
File '/home/app/web/vendor/bundle/ruby/3.0.0/gems/dice_bag-1.6.0/lib/dice_bag/templates/databases/postgres.yml' created

@mdsol/architecture-enablement @jcarres-mdsol

Copy link
Contributor

@jfeltesse-mdsol jfeltesse-mdsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jcarres-mdsol jcarres-mdsol merged commit d8c927f into develop Feb 3, 2022
@jcarres-mdsol jcarres-mdsol deleted the feature/erb_trim_mode_bundle_path branch February 3, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants