New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong order of needle/haystack in Matchers/Contains #5

Closed

enduro44 opened this issue Nov 13, 2020 · 1 comment

Contributor

enduro44 commented Nov 13, 2020

public function matches($value): bool { return strpos($this->getCheckValue()->get(), $value) !== false; }
I guess it should be other way around

return strpos($value, $this->getCheckValue()->get()) !== false;

The text was updated successfully, but these errors were encountered:

Contributor Author

enduro44 commented Nov 13, 2020

I've created small PR to fix this #6

mcustiel pushed a commit that referenced this issue


          #5 Fix wrong order of needle/haystack in Matchers/Contains (#6)

1412e1f

mcustiel closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment