Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ERC-20 token for testing web3swift lib #50

Merged
merged 8 commits into from
Sep 28, 2018

Conversation

BaldyAsh
Copy link
Collaborator

No description provided.

@BaldyAsh
Copy link
Collaborator Author

@shamatar needs approvement

Copy link
Collaborator

@skywinder skywinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Fire it on mainnet, send the link on etherecan there and change the tests, to work with this named smart contract! 👍

@BaldyAsh
Copy link
Collaborator Author

Fired token on mainnet - https://etherscan.io/token/0x8932404a197d84ec3ea55971aade11cda1dddff1

@BaldyAsh
Copy link
Collaborator Author

@skywinder everything is done

Copy link
Collaborator

@skywinder skywinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small request about amount of tokens to check. everything else is fine!

guard case .success(let balance) = erc20token.getBalance(account: userAddress) else {return XCTFail()}
guard case .success(let allowance) = erc20token.getAllowance(originalOwner: userAddress, delegate: userAddress) else {return XCTFail()}
XCTAssert(String(balance) == "28986212")
XCTAssert(String(balance) == "0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 doesn't check anything.
Put some balance to your account, let this check more useful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skywinder fixed

@BaldyAsh
Copy link
Collaborator Author

@shamatar please make your feedback

Copy link
Contributor

@shamatar shamatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add extra copy to Rinkeby to test actual sends

@shamatar shamatar merged commit f0c3ace into develop Sep 28, 2018
@BaldyAsh BaldyAsh deleted the feature/testTokenCreation branch October 2, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants