Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let some functions public for customization #132

Merged
merged 1 commit into from
Mar 26, 2019

Conversation

scottphc
Copy link
Contributor

No description provided.

public var jsonrpc: String = "2.0"
public var method: JSONRPCmethod?
public var params: JSONRPCparams?
public var id: UInt64 = Counter.increment()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that public constructor for a “Dispatcher” may be necessary, but request should not be messed up with (or please provide a concrete example for what reason). May be extending a list of JSONRPCmethod is better approach?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to integrate web3 with native wallet app and need to read method/params/id to determine whether to intercept the request. For example, I want to intercept eth.sendTransaction request and handle it by myself, so I need to know method first and then use id / params to process the request.

@BaldyAsh BaldyAsh merged commit dd700be into web3swift-team:develop Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants