Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access control of function fromRaw in struct EthereumTransaction #11

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

Plazmathron
Copy link
Contributor

No description provided.

@skywinder
Copy link
Collaborator

@skywinder
Copy link
Collaborator

skywinder commented Sep 5, 2018

@FesenkoG @BaldyAsh your attention needed. Let 's think, how can we organize access control for the functions? what about separate protocol (interfaces) for exporting rawTransactions\jsons etc.?

@skywinder
Copy link
Collaborator

@Plazmathron thanks for your first contribution! Welcome to the team!
May I ask, where are you using this library?

@skywinder skywinder added the good first issue Good for newcomers label Sep 5, 2018
@Plazmathron
Copy link
Contributor Author

Plazmathron commented Sep 5, 2018 via email

@shamatar
Copy link
Contributor

shamatar commented Sep 5, 2018

I'm developing a wallet for the ETH. ...

@Plazmathron oh, I see.

For now I’ll not rework the API from scratch, it’s planned for 2.0 release, so this patch is fine

Sincerely, Alex

Sent with GitHawk

@shamatar shamatar merged commit c232d91 into web3swift-team:master Sep 5, 2018
BaldyAsh added a commit that referenced this pull request Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants