Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Web3View functionality #30

Closed
alex78pro opened this issue Sep 12, 2018 · 4 comments
Closed

Support Web3View functionality #30

alex78pro opened this issue Sep 12, 2018 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@alex78pro
Copy link
Contributor

alex78pro commented Sep 12, 2018

Can you add feature to support delegate methods from WKWebView like web3view for TrustWallet on Android using your library:

Setters:
web3View.setChainID(chainID)
web3View.setChainType(chainType) // tesnet, mainet
web3View.setRpsUrl(url)
web3View.setWalletAddress(addressString)

Delegate methods:
web3View.setOnSignMessage(message) {
    print(message)
    web3View.signMessage()
}

web3View.setOnSignPersonalMessage(message) {
    print(message)
    web3View.signMessage()
}

web3View.setOnSignTransaction(transaction) {
    print(transaction)
    web3View.signMessage()
}

Send results:
web3View.signMessageCancel()
web3View.signMessageSuccessful(message, signedMessage)
web3View.signPersonalMessage(message, signedMessage)
web3View.signTransactionSuccessful(transaction, signedTx)
@shamatar
Copy link
Contributor

Oh, making a pre-setup WkWebView is actually a great idea, thanks, will work on it

@vadimicus
Copy link

Oh, making a pre-setup WkWebView is actually a great idea, thanks, will work on it

Not only pre-setup but also possibility to catch custom events and use it in some additional logic.

..something like this

web3View.setOnSignTransaction(transaction) {
    myAwesomeLogic(transaction)
}

@skywinder skywinder added the enhancement New feature or request label Sep 20, 2018
@BaldyAsh
Copy link
Collaborator

Already done in 2.0

@alex78pro
Copy link
Contributor Author

alex78pro commented Nov 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants