Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn print statements into logging #27

Open
stephantul opened this issue May 7, 2023 · 6 comments
Open

Turn print statements into logging #27

stephantul opened this issue May 7, 2023 · 6 comments

Comments

@stephantul
Copy link

Hi!

Thanks for writing this package, it looks great!

I'd be interested in turning the print statements (with verbose=True) into logging statements. The verbose flag could then be used to control whether this logging is output to stdout (i.e., by setting the log level). Is this something you are interested in? if so, I could submit a PR.

@matsui528
Copy link
Owner

Thanks! Just wait a bit, I need to take a look at this PR first #24 (I haven't had time to work on this PR for a long time, though...)

Once that is done, please make a PR! As I'd like to keep this repository as simple as possible, very simple logging is appreciated :)

@stephantul
Copy link
Author

Thanks for the response, I'll wait! If you want, you can ping me when this can be started.

@matsui528
Copy link
Owner

@stephantul Sorry for the super long delay... Now you can start 👍

@DivyanshVinayak23
Copy link

If this is still open can I work on this?

@stephantul
Copy link
Author

@DivyanshVinayak23 Sure, I totally forgot to pick this up. (@matsui528 my apologies 🙏 )

@matsui528
Copy link
Owner

@DivyanshVinayak23 @stephantul Thanks! Please go ahead 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants