Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Experimental support for checking space membership when a local user joins a restricted room #9714

Closed
clokep opened this issue Mar 30, 2021 · 0 comments · Fixed by #9735
Closed

Experimental support for checking space membership when a local user joins a restricted room #9714

clokep opened this issue Mar 30, 2021 · 0 comments · Fixed by #9735
Assignees
@clokep
Labels
A-Spaces Hierarchical organization of rooms T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented Mar 30, 2021 •
edited
Loading

This is a follow-on to #9712 to implement the changes necessary when a client calls /join on a restricted room for MSC3083.

  • Figure out where to hook into the local join-room flow.
  • Check the space membership based on the allow parameter of the join_rules.
  • Reject if the server is not a member of the space. (The MSC talks a bit about peeking in this case, but this is being left unimplemented for now.)
@clokep clokep added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. A-Spaces Hierarchical organization of rooms labels Mar 30, 2021
@clokep clokep self-assigned this Mar 30, 2021
This was referenced Mar 30, 2021
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Spaces Hierarchical organization of rooms T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for space membership during a local join of restricted rooms. matrix-org/synapse
1 participant
@clokep