Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

mypy failing on Twisted 21.2.0 #9513

Closed
clokep opened this issue Mar 1, 2021 · 4 comments · Fixed by #9678
Closed

mypy failing on Twisted 21.2.0 #9513

clokep opened this issue Mar 1, 2021 · 4 comments · Fixed by #9678
Assignees
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Mar 1, 2021

The mypy check is failing on 21.2.0, which adds significantly more type hints internal to Twisted.

There's currently 196 errors, but hopefully it isn't too bad to clean them up!

@clokep
Copy link
Member Author

clokep commented Mar 10, 2021

Filed Shoobx/mypy-zope#34 about an issue I'm having...

@clokep
Copy link
Member Author

clokep commented Mar 12, 2021

Filed Shoobx/mypy-zope#34 about an issue I'm having...

It seems that mypy-zope has an issue with using the mypy cache, not sure if there will be a solution, but for now runnig rm -r .mypy_cache removes some spurious errors.

@clokep
Copy link
Member Author

clokep commented Mar 15, 2021

This is all "fixed" now, minus the issue with the mypy cache. I'm not sure what to do about this. We can:

  • Leave it and ignore the issue.
  • Add a rm .mypy_cache to the lint.sh script.

I don't have other ideas. 😄

@callahad
Copy link
Contributor

Decision:

  1. Apply the rm hack to lint.sh as a stopgap
  2. (Briefly) look into upstream code to scope how difficult it would be to supply a patch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants