This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Allow moving typing off master #7869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always building EDUs on the writer process and using the federation send queue to stream to the federation senders, we manage sending of EDUs on the federation senders by looking at typing replication stream. This means we also have to move the timers for federation pokes to the federation sending processes too.
erikjohnston
force-pushed
the
erikj/split_out_typing_2
branch
from
54148b1
to
1342863
Compare
erikjohnston
force-pushed
the
erikj/split_out_typing_2
branch
from
1342863
to
f65b828
Compare
clokep
reviewed
Jul 16, 2020
clokep
reviewed
Jul 16, 2020
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
clokep
reviewed
Jul 16, 2020
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
clokep
reviewed
Jul 16, 2020
Comment on lines
+66
to
+72
| # map room IDs to serial numbers | ||
| self._room_serials = {} | ||
| # map room IDs to sets of users currently typing | ||
| self._room_typing = {} | ||
|
|
||
| self._member_typing_until = {} # clock time we expect to stop | ||
| self._member_last_federation_poke = {} | ||
|
|
||
| self.wheel_timer = WheelTimer(bucket_size=5000) |
There was a problem hiding this comment.
We could just call self._reset here, but I suspect this code was all copy and pasted. 😄
There was a problem hiding this comment.
Yeeeeeeeeeeeeeees, though I'm not a huge fan of declaring attributes in not __init__ tbh :)
There was a problem hiding this comment.
Ah, that's true. I think type checkers don't like that. :)
This was referenced Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of this is various bits of rejigging, so probably worth looking at the commits.