This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add the option to validate the iss and aud claims for JWT logins.
#7827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/jwt-improvements
branch
from
eef4fe2
to
d6357e0
Compare
erikjohnston
approved these changes
Jul 14, 2020
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '77d2c0541': Add the option to validate the `iss` and `aud` claims for JWT logins. (#7827)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7818
This adds two optional fields to the JWT configuration to validate the
issandaudclaims of a JWT. There's some more information about these at in the PyJWT docs. Note that the claims are handled slightly differently if the configuration is not provided,issclaims are essentially ignored, but anaudclaim will cause validation to fail.Both are simple strings that are compared by comparison.
This updates the documentation and tests, but also slightly changes error handling for JWT logins to catch any PyJWT errors and convert them to
LoginError.I debated about making a separate
JwtHandler, but this didn't end up adding too much code to the login REST servlet.