Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Failure to download image for URL preview should not fail the whole preview #5298

Closed
turt2live opened this issue May 30, 2019 · 6 comments · Fixed by #12950
Closed

Failure to download image for URL preview should not fail the whole preview #5298

turt2live opened this issue May 30, 2019 · 6 comments · Fixed by #12950
Assignees
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@turt2live
Copy link
Member

Currently Synapse uses OpenGraph to try and find an image. If that fails, it'll pick an image from the DOM. If the image from either fails to download (403, 404, too large, etc) then Synapse should just return a preview without an image. Currently, it instead throws a 502 error instead.

@akontsevich
Copy link

изображение
This is preview from Skype, for example. However it is not the only problem: as I mentioned nothing from youtube works, many other sites like this: https://hdrezka-me.me/22654-teni-ischezayut-v-polden-95051943.html, livejournal, etc - nothing works actually.

@akontsevich
Copy link

Inserting new youtube link shows preview, however all previous links or on next days links are not previewed. So could be both synapse and client bugs.

@neilisfragile neilisfragile added z-p2 (Deprecated Label) z-bug (Deprecated Label) labels Jun 7, 2019
@akontsevich
Copy link

Happen again today for some links, yesterday preview was normal for that link, for example:
https://rezka.ag/series/drama/13646-blokada.html

@Kevin-Mok
Copy link

Kevin-Mok commented Sep 3, 2019

I have a site hosting Twitch emotes that I used to reference to preview the emote. It was just working the last couple of days but suddenly stopped working. Previews from other images not on that site still work fine, so I'm not sure what happened.

It used to just work like this but now doesn't show anything, even though the link is still valid:
7d37a7c0876078d3

Edit: They started working again after a few hours.

@akontsevich
Copy link

Issue appeared again. Please fix!

@akontsevich

This comment was marked as off-topic.

@MadLittleMods MadLittleMods added the T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. label Apr 25, 2022
@clokep clokep self-assigned this Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants