Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Synapse v1.84.0 is not happy to start workers that have no or empty instance_maps #15669

Closed
reivilibre opened this issue May 25, 2023 · 1 comment
Closed

Synapse v1.84.0 is not happy to start workers that have no or empty instance_maps #15669

reivilibre opened this issue May 25, 2023 · 1 comment
Assignees
@reivilibre
Labels
A-Config Configuration, or the documentation thereof S-Critical Blocks development, potential data loss, more than 25% of users possibly affected, no workarounds. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release

Comments

@reivilibre
Copy link
Contributor

Example error: Instance 'master' not in 'instance_map' config
@reivilibre reivilibre added the X-Regression Something broke which worked on a previous release label May 25, 2023
@reivilibre reivilibre self-assigned this May 25, 2023
@reivilibre reivilibre mentioned this issue May 25, 2023
Merged
reivilibre added a commit that referenced this issue May 25, 2023
@reivilibre
Fix #15669: always populate instance map even if it was empty
1f1ff51
@reivilibre reivilibre added A-Config Configuration, or the documentation thereof S-Critical Blocks development, potential data loss, more than 25% of users possibly affected, no workarounds. X-Release-Blocker Must be resolved before making a release labels May 25, 2023
@reivilibre
Copy link
Contributor Author

I intend to cut a point release to fix this tomorrow, provided I can find someone to review the change in #15672.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@reivilibre reivilibre

Labels
A-Config Configuration, or the documentation thereof S-Critical Blocks development, potential data loss, more than 25% of users possibly affected, no workarounds. X-Regression Something broke which worked on a previous release X-Release-Blocker Must be resolved before making a release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reivilibre