This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Remove delay when rotating event push actions #13211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.
erikjohnston
commented
Jul 7, 2022
| @@ -1109,7 +1107,7 @@ def remove_old_push_actions_that_have_rotated_txn( | |||
| ) -> bool: | |||
| # We don't want to clear out too much at a time, so we bound our | |||
| # deletes. | |||
| batch_size = 10000 | |||
| batch_size = self._rotate_count | |||
There was a problem hiding this comment.
Oh, and this is just so that it's easier to mess about with via the manhole
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.