Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3089: File tree structures #3089

Draft
wants to merge 3 commits into
base: old_master
Choose a base branch
from
Draft

MSC3089: File tree structures #3089

wants to merge 3 commits into from

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Apr 2, 2021

Rendered

Partial implementation: matrix-org/matrix-js-sdk#1732

@turt2live turt2live marked this pull request as draft April 2, 2021 22:26
@turt2live turt2live added client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff proposal A matrix spec change proposal labels Apr 2, 2021
@turt2live

This comment has been minimized.

@turt2live turt2live added the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Jun 8, 2021
@turt2live turt2live self-assigned this Jun 8, 2021
"type": "m.branch",
"state_key": "$event",
"content": {
"active": true
Copy link
Member Author

@turt2live turt2live Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for mostly myself: we include a file name here to make simple edits easier.

edit: as name: string

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also locked: true for file locking

turt2live added a commit to matrix-org/matrix-js-sdk that referenced this pull request Jun 10, 2021
MSC: matrix-org/matrix-spec-proposals#3089
Includes part of MSC3088 (room subtyping): matrix-org/matrix-spec-proposals#3088

The NamespacedValue stuff is borrowed from the Extensible Events implementation PR in the react-sdk as a useful thing to put here. When/if the MSCs become stable, we'd convert the values to enums and drop the constants (or keep them for migration purposes, but switch to stable). 

This flags the whole thing as unstable because it's highly subject to change.
*Author's note: This proposal assumes the reader is familiar with the terminology of the reading
materials mentioned above.*

We introduce a new room subtype, `m.data_tree`, to be applied to spaces to denote that they are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say "room subtype" here, should I assume MSC3088 m.room.purpose state events with a state key of m.data_tree? (There's enough MSCs that mention types floating around that I'm having trouble distinguishing them all...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry. Will leave this open as a reminder to clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants