clerk/client/rest :: add : blocktime check in recordListHandlerFn #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #993 +/- ##
========================================
Coverage 75.41% 75.41%
========================================
Files 49 49
Lines 5296 5296
========================================
Hits 3994 3994
Misses 1068 1068
Partials 234 234 ☔ View full report in Codecov by Sentry. |
manav2401
approved these changes
May 25, 2023
0xsharma
changed the title
VAIBHAVJINDAL3012
approved these changes
May 25, 2023
marcello33
approved these changes
May 25, 2023
cffls
reviewed
May 25, 2023
cffls
approved these changes
May 25, 2023
mh0lt
pushed a commit
to erigontech/erigon
that referenced
this pull request
Dec 30, 2023
…se (#9103) Users reported this error ``` [bor.heimdall] an error while trying fetching path=clerk/event-record/list attempt=5 error="unexpected end of JSON input" ``` Which may happen if: 1. Heimdall is behind and not sync-ed - for more info check maticnetwork/heimdall#993 2. Or the header time erigon is sending is far into the future The logs in this PR will help us see which of the 2 is the culprit but most likely it is 1. We will investigate further 2. if it ever happens. Changes: 1. Improves logging upon heimdall client retries - prints out the full url that failed. 2. Fixes a bug where the body was incorrectly checked if it is empty - `len(body) == 0` vs `body == nil` 3. Unit test for the bug regression 4. Adds a log to indicate to users to check their heimdall process if they run into this scenario since that may be the culprit Example output with new logs <img width="1465" alt="Screenshot 2023-12-29 at 20 16 57" src="https://github.com/ledgerwatch/erigon/assets/94537774/1ebfde68-aa93-41d6-889a-27bef5414f25">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle
heimdalld not in syncwhen bor is querying latest state-syncs for syncing blocks. In request we send 'to-time' timestamp. We returnnothingifto-time>heimdall_latest_block_timestamp