Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests for validator #118

Closed
4 tasks
hide-on-bush-x opened this issue Jun 26, 2024 · 3 comments
Closed
4 tasks

Integration tests for validator #118

hide-on-bush-x opened this issue Jun 26, 2024 · 3 comments

Comments

@hide-on-bush-x
Copy link
Contributor

hide-on-bush-x commented Jun 26, 2024

Based on #99

We need to test the validator every time we push new code, so, it is required to build some scripts or code to test some of the vital interactions with the miners and the metagraph

Testing list

  • Is the validator calling miners? Deploy a miner ( Dependency on docker setup ) and check if the miner gets a call from the deployed validator

  • Is the validator ignoring miners that don't meet the selection criteria? ( deploy a miner that doesn't meet the selection criteria and check if it's being ignored )

  • Setting weights ( Check if the weights are being set correctly after some calls to miners ) There is an example on the parent ticket #99 (link)

  • Check that the scores are being updated ( deploy a miner and make some calls to the validator api, check that the state.pt file is updated )

This scripts must be called from the GH actions set up on #117

@juanmanso
Copy link
Contributor

Based on the description, would you agree @hide-on-bush-x that this task is:

?

If so, i'd suggest to add the blocker label here

@Luka-Loncar
Copy link

We need to groom this on the next planning and get final agreement between eng team and devops on how the integration tests should look like and how they should be executed.

@Luka-Loncar
Copy link

Closing this because it is covered in #120 and #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants