Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn CI runs as PR checks for merging #108

Closed
juanmanso opened this issue Jun 21, 2024 · 1 comment
Closed

Turn CI runs as PR checks for merging #108

juanmanso opened this issue Jun 21, 2024 · 1 comment
Labels

Comments

@juanmanso
Copy link
Contributor

Description

After [tbd] and [tbd], our codebase is free of linting issues and CI is passing. So this task is for repo admins to turn on CI check for PRs

Accpetance criteria

  • Failing CI runs block merge of PRs
  • Properly formatted and linted code should not be blocked by CI to merge its PR

Related issues

@Luka-Loncar
Copy link

Wontfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants