Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled background painter causes ghost images #48

Closed
Frenkii opened this issue Feb 5, 2021 · 2 comments
Closed

Disabled background painter causes ghost images #48

Frenkii opened this issue Feb 5, 2021 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Frenkii
Copy link

Frenkii commented Feb 5, 2021

Describe the bug
When toggle the Enabled button for Date Line the overlays for i.e. active FIRs seems to stack

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Preferences, disable Background'
  2. Click on 'Date Line Enable toggle button and toggle i.e. 10 times'
  3. Observe the map when clicking again and again

Expected behavior
Only toggle the option and not stack the overlays on the map

Screenshots
Unbenannt

@Frenkii Frenkii added the bug Something isn't working label Feb 5, 2021
@Frenkii
Copy link
Author

Frenkii commented Feb 5, 2021

after moving the map:

Unbenannt

@Frenkii Frenkii changed the title Toggle Date Line causes Overlays get darker - maybe other toggles too? Toggle Date Line causes Overlays stacking - maybe other toggles too? Feb 5, 2021
@marvk
Copy link
Owner

marvk commented Feb 5, 2021

@Frenkii this should only happen when the background painter is disabled or a transparent color is set to it.

Each frame is painted completely from scratch and starts by painting the whole canvas with a big rectangle, which will form the ocean area after the land is painted on it. If that rectangle isn't painted, the last frame will stay on the canvas as a ghost image.

The toggle to disable the background painter, just like all painter settings, are currently generated automatically. In reality, it makes no sense to make the background disableable, so I will remove this toggle at the latest along with cleaning up the whole preferences dialog (#26).

@marvk marvk self-assigned this Feb 5, 2021
@marvk marvk added this to the 0.2.0 milestone Feb 5, 2021
@marvk marvk changed the title Toggle Date Line causes Overlays stacking - maybe other toggles too? Disabled background painter causes ghost images Feb 5, 2021
@marvk marvk closed this as completed in d68d98b Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants