Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semicolon not removed from hist completion (regression) #297

Closed
pcjmfranken opened this issue Jul 7, 2021 · 2 comments
Closed

Semicolon not removed from hist completion (regression) #297

pcjmfranken opened this issue Jul 7, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@pcjmfranken
Copy link

  • zsh-autocomplete version: Confirmed in d11612a and b164ae7 (current main)
  • Zsh version: 5.8
  • Framework: none
  • Plugin manager: none

Shell output:

% git config --get remote.origin.url
https://github.com/marlonrichert/zsh-autocomplete.git
% git config --get remote.origin.url;

Reproduction steps:

  1. Populate history by executing a command
  2. Type the first word of the command again
  3. Press to have it autocompleted from the history menu
  4. Press Space and you will see that the semicolon is not removed

Possible regression because of:

No need for a setting. The ; is now automatically removed for all input except CtrlSpace and AltSpace.

Originally posted by @marlonrichert in #141 (comment)

Let me know if you require more info!

@pcjmfranken pcjmfranken added the bug Something isn't working label Jul 7, 2021
@marlonrichert marlonrichert self-assigned this Jul 17, 2021
@marlonrichert
Copy link
Owner

Fixed.

@marlonrichert
Copy link
Owner

PS: If you enjoy using this software, please consider becoming a sponsor. 🙂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants