Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone issue #7

Closed
marcusyoung opened this issue Nov 1, 2019 · 1 comment
Closed

Timezone issue #7

marcusyoung opened this issue Nov 1, 2019 · 1 comment
Assignees

Comments

@marcusyoung
Copy link
Owner

marcusyoung commented Nov 1, 2019

At present for the itinerary start and end times to be presented correctly to the user, otpr needs to be running in the same time zone as the OTP graph that is being queried.

This is because otp_get_times() uses the R as.POSIXct() function to convert from the epoch time returned by OTP. By default, as.POSIXct will assume the current system time zone (i.e. on the system that is running otpr).

To fix this probably need:

  1. Ability to specify the timezone of the graph - perhaps this should be done as part of otp_connect() ?
  2. OTP handling of Time Zones is a bit opaque and a current discussion topic amongst the key developers. What I am understanding is that OTP is only intended to work across a single time zone and that this is picked up from the agency GTFS file. Needs further investigation. Therefore as there is a single graph per router, setting it as part of otp_connect() may make sense?
@marcusyoung marcusyoung self-assigned this Nov 2, 2019
@marcusyoung
Copy link
Owner Author

Completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant