Add one more status_log call #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One routine in marbl_diagnostics_mod (linear_root()) was still using print* to write to stdout; added a status_log argument to the interface and passed the message out.
|
Passes aux_pop_MARBL tests on yellowstone (intel and gnu), and builds successfully with nag on hobart. No change needed in the driver. |
To find a root between x(1) and x(2), we require either y(1) and y(2) to be opposite signs OR one of the two values to be 0. To check for a sign change, we originally look to see if y(1)*y(2) > 0... but in this commit we update that to explicitly look to see if (y(1) > 0 && y(2) > 0) or (y(1) < 0 && y(2) < 0). This offers two improvements over the old code: 1) more detailed error message (can now say "both y values are positive" or "both y values are negative" instead of "y values have same sign") 2) Avoid potential for underflow (multiplying two very small positive numbers could result in 0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One routine in marbl_diagnostics_mod (linear_root()) was still using print* to
write to stdout; added a status_log argument to the interface and passed the
message out.