Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add derecho support #436

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Add derecho support #436

merged 2 commits into from
Aug 7, 2023

Conversation

mnlevy1981
Copy link
Collaborator

Adds support for the nvhpc compiler and then recognizes derecho as a known machine (with intel, cray, nvhpc, and gnu compilers).

I should note that the netCDF Comparison (1 inst vs baseline) test fails on derecho for two reasons:

  1. some values of fields that we know are very small went from truly being 0 to being round-off level
  2. the threshold for acceptable relative errors in non-zero fields is exceeded

Both of these are addressed in #430 so I don't want to duplicate the fixes on this branch:

  1. Instead of flagging values where baseline = 0 and new value is non-zero, we flag values where baseline = 0 and |new value| exceeds something like 1e-16
  2. We have a different algorithm for computing relative error (denominator is the max over a three-point stencil), and have also adjusted the threshold. If this comparison still fails with the updated netcdf_comparison script, I'll increase the threshold accordingly

@mnlevy1981
Add support for nvhpc compiler
571e674 
I believe nvhpc has replaced the pgi compiler, but for now I'm keeping support
for both.

Also, it turns out that "make clean" was not removing .mod files; fixed that as
well.
@mnlevy1981
Add support for derecho
9175461 
Currently allows for intel, cray, nvhpc, and pgi compilers. Note that I don't
support the various permutations of intel (intel-oneapi, intel-classic); I
think intel-classic uses the same fortran compiler as intel, and I don't know
if the fortran compiler in intel-oneapi is still named "ifort" or if it is
something else.
@mnlevy1981 mnlevy1981 merged commit 523461f into marbl-ecosys:development Aug 7, 2023
1 check passed
@mnlevy1981 mnlevy1981 mentioned this pull request Aug 7, 2023
Merged
@mnlevy1981 mnlevy1981 deleted the add_derecho_support branch August 31, 2023 15:13
@mnlevy1981 mnlevy1981 mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mnlevy1981