Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize more arrays below kmt #372

Merged
merged 6 commits into from
Mar 16, 2021

Commits on Feb 25, 2021

  1. Initialize more arrays below kmt

    Running call_compute_subroutines with the intel compiler using the following
    FFLAGS: -g -O0 -init=snan,arrays crashed until I initialized several fields
    below the sea floor.
    mnlevy1981 committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    206077f View commit details
    Browse the repository at this point in the history
  2. Update gfortran compile flags to trap uninit reals

    Verified that using -finit-real=snan -ffpe-trap=invalid on the previous head of
    development causes the call_compute_subroutines test to crash but the code on
    the fix_uninit_mem branch (which eliminates unitialized values in the sinking
    particle type below the sea floor) runs successfully.
    mnlevy1981 committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    478d9df View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Refactor setting terms to 0 into new routine

    It turns out that we need PON_remin=0, but none of the %remin(k) terms are used
    if k > column_kmt. Introduced
    marbl_interior_tendency_share_set_used_particle_terms_to_zero() to handle
    setting sflux_out(k) and hflux_out(k) to 0. Next commit will add calls to the
    same subroutine in ciso (which currently isn't tested for uninitialized memory)
    mnlevy1981 committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    ffd7733 View commit details
    Browse the repository at this point in the history
  2. Set used particle terms to 0 in ciso

    Also added a comment to the else statement to make it clear which "if" it is
    tied to
    mnlevy1981 committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    4c8dee7 View commit details
    Browse the repository at this point in the history
  3. initialize dzr_loc in ciso code

    In the last commit I added calls to the new share routine to set hflux_out and
    sflux_out below the sea floor for ciso sinking particles but I forgot to add
    the additional dzr_loc = c0 line that is already in the non-ciso code and it
    was caught by our CI scripts.
    mnlevy1981 committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    d1a4771 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. Add -g -init=snan,arrays to ifort flags

    Testing on cheyenne with intel also showed that we need to intialize remin to 0
    below kmt in marbl_interior_tendency_share_set_used_particle_terms_to_zero()
    mnlevy1981 committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    dd7cb41 View commit details
    Browse the repository at this point in the history