Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MARBL version with explicit calcifiers #330

Merged
merged 82 commits into from
Jul 11, 2019

Commits on Jul 6, 2017

  1. Added cocco PFT

    kristenkrumhardt committed Jul 6, 2017
    Configuration menu
    Copy the full SHA
    8040287 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2017

  1. Added explicit calcifier cocco, else-if statements

    Kristen Krumhardt committed Jul 18, 2017
    Configuration menu
    Copy the full SHA
    6a0fcc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2017

  1. Added QCaCO3_max_exp parameter, modified cocco/sp growth parms

    kristenkrumhardt committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    a16a1e8 View commit details
    Browse the repository at this point in the history
  2. Modified parameters, need sp to be more competitive.

    kristenkrumhardt committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    bdf7c63 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2017

  1. Configuration menu
    Copy the full SHA
    d457281 View commit details
    Browse the repository at this point in the history
  2. Changed QCaCO3_max to 1.0

    kristenkrumhardt committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    72c5d37 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2017

  1. Parms changed: increased cocco kNO3, decreased cocco thetaNmax, incre…

    …ased cocco gQfe_0
    kristenkrumhardt committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    01374e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2017

  1. Increased thetaNmax for coccos

    kristenkrumhardt committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    f2e7b0f View commit details
    Browse the repository at this point in the history
  2. Lower alphaPI and thetaNmax for coccos, lower KFe for diat, higher PC…

    …ref for diat
    kristenkrumhardt committed Jul 24, 2017
    Configuration menu
    Copy the full SHA
    094ec1e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2017

  1. diat PCref is now 5.2, diat kFe is 0.5

    kristenkrumhardt committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    505c8b8 View commit details
    Browse the repository at this point in the history
  2. Lower cocco gQfe_0 to 15., cocco alphaPI increased to 0.30

    kristenkrumhardt committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    cd5b2c4 View commit details
    Browse the repository at this point in the history
  3. made temp_thres for coccos 0.

    kristenkrumhardt committed Jul 25, 2017
    Configuration menu
    Copy the full SHA
    fdbb366 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2017

  1. Added modulation of calcification by Plim,CO2,temp and growth rate by…

    … C lim
    kristenkrumhardt committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    317ba2a View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2017

  1. More modifications to try to get modulated calcification and Clim to …

    …work.
    kristenkrumhardt committed Aug 3, 2017
    Configuration menu
    Copy the full SHA
    1b7ad53 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2017

  1. Configuration menu
    Copy the full SHA
    793f3e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2017

  1. reinstated increased pic/poc with Plim, modified parms to make coccos…

    … slightly more competitive
    kristenkrumhardt committed Aug 7, 2017
    Configuration menu
    Copy the full SHA
    8472fa9 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2017

  1. further decreased KFe for coccos and increased thetaNmax to 3.2 for c…

    …occos
    kristenkrumhardt committed Aug 8, 2017
    Configuration menu
    Copy the full SHA
    be0c37a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2017

  1. decreased kCO2 for cocco, decreased Kno3 for cocco, increased alphaPI…

    … for cocco
    kristenkrumhardt committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    77f4e3c View commit details
    Browse the repository at this point in the history
  2. Made a special Tfunc for coccos

    kristenkrumhardt committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    f30c99e View commit details
    Browse the repository at this point in the history
  3. test with no C lim

    kristenkrumhardt committed Aug 9, 2017
    Configuration menu
    Copy the full SHA
    2692ef2 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2017

  1. decreased competitive ability of coccos, given new Tfunc

    kristenkrumhardt committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    897d80d View commit details
    Browse the repository at this point in the history
  2. made the Tfunc for coccos to version 2 (not so advantageous)

    kristenkrumhardt committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    7b0d23f View commit details
    Browse the repository at this point in the history
  3. oops

    kristenkrumhardt committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    1ae38eb View commit details
    Browse the repository at this point in the history
  4. change to Tfunc to version 2

    kristenkrumhardt committed Aug 10, 2017
    Configuration menu
    Copy the full SHA
    132139d View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2017

  1. lowered max growth rate for coccos

    kristenkrumhardt committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    52c0fbb View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2017

  1. temp function changes

    Kristen Krumhardt committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    c2d4d59 View commit details
    Browse the repository at this point in the history
  2. made light lim cocco same as for diat and really efficient Kfe for co…

    …ccos
    kristenkrumhardt committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    82badc4 View commit details
    Browse the repository at this point in the history
  3. coccos have the same light parms as diatoms, but with super efficent …

    …Kfe and with the blue Tfunc for coccos
    kristenkrumhardt committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    f7a88e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2017

  1. increase kco2

    kristenkrumhardt committed Aug 16, 2017
    Configuration menu
    Copy the full SHA
    e13413d View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2017

  1. adjusting parms

    Kristen Krumhardt committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    4f7e403 View commit details
    Browse the repository at this point in the history
  2. adjusted parms

    kristenkrumhardt committed Aug 29, 2017
    Configuration menu
    Copy the full SHA
    6c89c00 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2017

  1. adjusting light parms

    kristenkrumhardt committed Aug 30, 2017
    Configuration menu
    Copy the full SHA
    c265971 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2017

  1. more parm adjustements

    kristenkrumhardt committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    e893558 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2017

  1. adjusting light parms

    kristenkrumhardt committed Sep 1, 2017
    Configuration menu
    Copy the full SHA
    f8c5600 View commit details
    Browse the repository at this point in the history
  2. going back to version 20 parms

    kristenkrumhardt committed Sep 1, 2017
    Configuration menu
    Copy the full SHA
    4dbd222 View commit details
    Browse the repository at this point in the history
  3. adjust parms

    kristenkrumhardt committed Sep 1, 2017
    Configuration menu
    Copy the full SHA
    946eea4 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2017

  1. parm adjustments

    kristenkrumhardt committed Sep 2, 2017
    Configuration menu
    Copy the full SHA
    8407165 View commit details
    Browse the repository at this point in the history
  2. test

    kristenkrumhardt committed Sep 2, 2017
    Configuration menu
    Copy the full SHA
    2481ee9 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2017

  1. put my light parms like Cara's

    kristenkrumhardt committed Sep 3, 2017
    Configuration menu
    Copy the full SHA
    68a46f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2017

  1. lowered cocco KNO3

    kristenkrumhardt committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    92b8c79 View commit details
    Browse the repository at this point in the history
  2. thetaNmax for cocco same as sp, lowered KNO3 for cocco, increased KSi…

    …O3 for diat
    kristenkrumhardt committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    0a4977f View commit details
    Browse the repository at this point in the history
  3. adjusting a bunch of parms to make coccos more competitive

    kristenkrumhardt committed Sep 5, 2017
    Configuration menu
    Copy the full SHA
    104930e View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2017

  1. adjusted light parms and some nutrient kms to make coccos more compet…

    …itive
    kristenkrumhardt committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    4557fad View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2017

  1. change cocco grazing function to sigmoidal

    kristenkrumhardt committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    63d6d39 View commit details
    Browse the repository at this point in the history
  2. after adding grazing, need to make Km for nuts bigger for coccos/less…

    … for sp
    kristenkrumhardt committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    088574f View commit details
    Browse the repository at this point in the history
  3. made sp more competitive nutrient-wise

    kristenkrumhardt committed Sep 7, 2017
    Configuration menu
    Copy the full SHA
    a7891c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2017

  1. try making sp with sigmoidal grazing too

    kristenkrumhardt committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    86c9497 View commit details
    Browse the repository at this point in the history
  2. changed everyone to sigmoidal grazing

    kristenkrumhardt committed Sep 8, 2017
    Configuration menu
    Copy the full SHA
    3d94feb View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2017

  1. made max growth rate for coccos 4.5 d-1, a few other adjustments in p…

    …arms (too much cocco)
    kristenkrumhardt committed Sep 9, 2017
    Configuration menu
    Copy the full SHA
    3328949 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2017

  1. Configuration menu
    Copy the full SHA
    5955a8b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2017

  1. coccos were still too much, adjusted alphaPI, PCref, grazing

    kristenkrumhardt committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    c52ca96 View commit details
    Browse the repository at this point in the history
  2. adjusting parms

    kristenkrumhardt committed Sep 11, 2017
    Configuration menu
    Copy the full SHA
    6a2bfe3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2017

  1. switch back to mm grazing

    kristenkrumhardt committed Sep 12, 2017
    Configuration menu
    Copy the full SHA
    9ff5a6c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2017

  1. grazing parms identical between sp and cocco, changing back to sigmoi…

    …dal grazing
    kristenkrumhardt committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    d7685f9 View commit details
    Browse the repository at this point in the history
  2. identical sp and cocco grazing parms, michaelis-menten grazing

    kristenkrumhardt committed Sep 13, 2017
    Configuration menu
    Copy the full SHA
    a3efd24 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2017

  1. Merge branch 'master' into modify_Tfunc

    Conflicts:
    	src/Makefile
    	src/marbl_config_mod.F90
    	src/marbl_diagnostics_mod.F90
    	src/marbl_interface_private_types.F90
    	src/marbl_mod.F90
    	src/marbl_parms.F90
    	src/marbl_sizes.F90
    	tests/driver_src/Makefile
    Kristen Krumhardt committed Sep 19, 2017
    Configuration menu
    Copy the full SHA
    bd818e6 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2017

  1. making changes in the marbl master for coccos

    Kristen Krumhardt committed Sep 20, 2017
    Configuration menu
    Copy the full SHA
    7715641 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2018

  1. Fixed picpoc calculations so they cannot go negative

    Kristen Krumhardt committed Mar 16, 2018
    Configuration menu
    Copy the full SHA
    f25c9e7 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2018

  1. Slightly modified Tfunc_cocco, Tfunc_cocco modifies cocco mortality, …

    …CaCO2 dissolution in zooplankton guts increased to 0.7
    Kristen Krumhardt committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    551d159 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ed4a30 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1 from mnlevy1981/modify_Tfunc

    Modify tfunc
    kristenkrumhardt authored Apr 24, 2018
    Configuration menu
    Copy the full SHA
    6e18203 View commit details
    Browse the repository at this point in the history
  4. fixed a few bugs concerning C limitation in marbl_diagnostics; fixed …

    …bug concerning temperature in marbl_mod; changed default settings.yaml to accomodate coccos
    Kristen Krumhardt committed Apr 24, 2018
    Configuration menu
    Copy the full SHA
    9744532 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. add CaCO3_prod to output, add cocco_C_lim to output

    Kristen Krumhardt committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    06a95b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Merge branch 'development' into modify_Tfunc

    Conflicts:
    	src/marbl_diagnostics_mod.F90
    	src/marbl_mod.F90
    	src/marbl_pft_mod.F90
    	src/marbl_settings_mod.F90
    Kristen Krumhardt committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    9d6deb2 View commit details
    Browse the repository at this point in the history
  2. add kco2 to autotroph settings

    Kristen Krumhardt committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    8b326ea View commit details
    Browse the repository at this point in the history

Commits on May 15, 2019

  1. Bring latest development branch in modify_Tfunc

    Includes SPECTRA support
    Kristen Krumhardt committed May 15, 2019
    Configuration menu
    Copy the full SHA
    59d9c51 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2019

  1. Add is_carbon_limited to autotroph_settings_type

    Also, only include C_lim diagnostics for carbon limited diagnostics.
    mnlevy1981 committed May 30, 2019
    Configuration menu
    Copy the full SHA
    4727ca0 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2019

  1. Make temp_func_form_opt and Tref per-PFT settings

    Also, introduce the temp_func_form_opt = 'power' option (which will be
    used by coccolithophores). Note that this commit changes the default
    Tref behavior -- rather than depending on temp_func_form_opt (Tref = 30
    for q_10 and Tref = 25 for arrhenius), the default is currently based on
    the PFT shortname and set to 30 for all current PFTs. I have some ideas
    on how to change the way we apply dependencies to allow Tref to depend
    on the per-autotroph temp_func_form_opt but haven't implemented that
    yet.
    mnlevy1981 committed May 31, 2019
    Configuration menu
    Copy the full SHA
    6c1e0b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. Tref is no longer available from input file

    Tref is still in the PFT settings_type data structures, but values are
    derived based on temp_func_form_opt (30 for q_10, 25 for arrhenius, and
    0 for power -- note that the power function doesn't use the Tref
    parameter)
    mnlevy1981 committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    eea4b1e View commit details
    Browse the repository at this point in the history
  2. Remove Tref from default files

    MARBL_generate_settings_file was still putting Tref in the input files
    because it was in the settings file.
    mnlevy1981 committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    c653a12 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Create two new settings files

    cesm2.1 will match the final configuration of MARBL in the CESM 2.1 release
    (while future tuning changings will go into settings_latest). The cesm2.1+cocco
    file will contain settings for Kristen's coccolithophore runs, but in this
    commit is identical to the latest settings.
    mnlevy1981 committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    5937fcf View commit details
    Browse the repository at this point in the history
  2. Update values in settings_cesm2.1+cocco.yaml

    Something to look at in code review: I added a workaround to
    marbl_settings_mod.F90 to set PFT_defaults = 'user-specified' if the namelist
    uses 'CESM2.1+cocco'; I can't use 'CESM2' because that will get the autotroph
    count wrong, and we intentionally did not hard-code the cocco settings in the
    fortran code so this seemed like a necessary step.
    mnlevy1981 committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    fd4c119 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Remove QCaCO3_max_exp

    Now that we have cesm2.1+cocco settings file, we can set QCaCO3_max to
    different values when using coccolithophores instead of needing a
    separate settings variable.
    mnlevy1981 committed Jun 14, 2019
    Configuration menu
    Copy the full SHA
    9cc23d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. Re-order compute_temperature_functional_form args

    intent(out) variable should be last (also added comments defining
    dimensions of each argument)
    mnlevy1981 committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    31bbb03 View commit details
    Browse the repository at this point in the history
  2. Update comments in marbl_pft_mod

    Some default variable settings were missing the comment to see the CESM
    NOTE in marbl_settings_mod, others had an incorrect message (claiming
    the CESM NOTE was in marbl_pft_mod rather than settings_mod).
    
    Also, changed the order in which the autotroph settings are set so that
    it matches the order variables appear in the settings YAML file.
    mnlevy1981 committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    664c6d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. Merge in code clean-up following review

    Several small issues were raised in code review on May 22nd, and this
    merge fixes most of them
    mnlevy1981 committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    d7b5533 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. cleaned up comments in calcification subroutine of marbl_interior_ten…

    …dency_mod.F90 and switched CaCO3_PROD output from medium to low in diagnostics_lastest.yaml
    Kristen Krumhardt committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    116007e View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Clean up comments and variable names

    Following the refactor to move Tref and temp_func_form_iopt onto the autotroph
    and zooplankton settings types, the variable Tfunc_ind was no longer an
    appropriate name (it wasn't just indexing Tfunc). So Tfunc_ind is now PFT_ind
    (matching the "PFT_cnt" dimension in the comments). I also cleaned up the
    comments about Tref in the function header to note that the setting is not used
    when Tfunc is computed with the power function.
    mnlevy1981 committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    acd6dfa View commit details
    Browse the repository at this point in the history
  2. Run yaml_to_json.py

    116007e changed diagnostics_latest.yaml but did not change the JSON file
    mnlevy1981 committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    133cb03 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Clean up whitespace

    Missing a space between variable name and '==' operator
    mnlevy1981 committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    3398c30 View commit details
    Browse the repository at this point in the history
  2. Update PFT_keys in more generic manner

    This will make it easier to add additional valid values for PFT_defaults
    in different settings files
    mnlevy1981 committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    1c52917 View commit details
    Browse the repository at this point in the history
  3. Clean up python code following review

    Fixed poor spacing around operator in MARBL_share.py and also improved
    the in determining proper values of append_to_keys and PFT_keys in
    MARBL_settings_file_class.py
    mnlevy1981 committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    047eb26 View commit details
    Browse the repository at this point in the history