Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/remove non living tracer cnt #165

Merged
merged 3 commits into from
May 31, 2017
Merged

Enhancement/remove non living tracer cnt #165

merged 3 commits into from
May 31, 2017

Commits on May 26, 2017

  1. non_living_tracer_cnt can be local var

    marbl_init_tracer_metadata() passes non_living_biomass_ecosys_tracer_cnt to
    marbl_init_non_autotroph_tracer_metadata(), where it is an intent out. However,
    the variable is only used in the non_autotroph_tracer_metadata() [it is not
    used after being returned], so I updated the interface accordingly.
    
    Next commit will look at how to remove it altogether.
    mnlevy1981 committed May 26, 2017
    Configuration menu
    Copy the full SHA
    b0744f8 View commit details
    Browse the repository at this point in the history
  2. Refactor marbl_init_non_autotroph_tracer_metadata

    What was previously marbl_init_non_autotroph_tracer_metadata has been renamed
    so that tracer is plural: marbl_init_non_autotroph_tracers_metadata; a new
    marbl_init_non_autotroph_tracer_metadata routine has been introduced for
    changing the metadata one tracer at a time. This removes the need for
    non_living_biomass_ecosys_tracer_cnt, which was implicitly requiring that the
    non-living biomass tracers had tracer indices 1 - N.
    
    Also fixed a typo in an error traceback.
    mnlevy1981 committed May 26, 2017
    Configuration menu
    Copy the full SHA
    769c468 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2017

  1. Clean up marbl_init_non_autotroph_tracer_metadata

    Removed a couple of un-necessary arguments from the subroutine interface, which
    also let me remove an associate statement in
    marbl_init_non_autotroph_tracers_metadata.
    mnlevy1981 committed May 29, 2017
    Configuration menu
    Copy the full SHA
    de6564f View commit details
    Browse the repository at this point in the history