-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loop to kmt instead of km? #176
Comments
@klindsay28 ran into a floating point exception that was not being trapped consistently, and traced it back to sub-seafloor values of Given the state of the CESM tests, it would be useful to test the MARBL stand-alone driver with these flags and fix any issues detected. This will require #156 to be completed, which we want done before addressing the |
In putting together a stand-alone driver test for
with the last 5 values occasionally changing (e.g.
For now I'll have the test only write values down to |
Get num_active_levels from marbl_instances%domain%kmt (and revert back to write_diag() call that does not highlight marbl-ecosys#176) Note that this is a good step towards different columns with different KMTs being treated correctly, though I still need to move the read_domain call into the num_inst loop.
Many loops inside MARBL run from
1:km
, meaning computation is often being done in levels below the sea floor. We should look into having loops run from1:kmt
instead (probably requires stricter initialization of arrays to avoid undefined values below the sea floor).The text was updated successfully, but these errors were encountered: