Don't convert null to the string "null" #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope this is an acceptable change, although I don't know the complete requirements of this package, but this fix will solve mapbox/mapbox-gl-js#8497. I also have a hard time thinking of a reason it would make sense to have null as a string `"null"` because of the ambiguity it brings.
|
Is this project still maintained by mapbox? Who can merge this PR? @anandthakker |
|
@cafca yep! Sorry for the late response — I'll do some much-needed maintenance on vt-pbf this week, including this PR. |
|
Any update on this PR? It's still an issue :) |
mourner
approved these changes
May 19, 2021
|
This change causes vector tiles to be created that violate the current vector tile spec and cannot be uploaded to Mapbox. #42 |
|
@ericfischer thanks for uncovering this! Please check out #43 as a potential fix. |
robinsummerhill
added a commit
to emuanalytics/vt-pbf
that referenced
this pull request
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is an acceptable change, although I don't know the complete requirements of this package, but this fix will solve mapbox/mapbox-gl-js#8497.
I can't think of a reason it would make sense to have null as a string
"null"because of the ambiguity it brings. Rather make it an empty string if there is a requirement for it to be a string.