Introduce minPoints option #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2020
zmiao
reviewed
Jun 3, 2020
| } else { // left points as unclustered | ||
| clusters.push(p); | ||
|
|
||
| if (numPoints > 1) { |
There was a problem hiding this comment.
I am curious why we compare numPoints with 1 instead of numPointsOrigin?
There was a problem hiding this comment.
When numPointsOrigin is bigger than 1, it means that the origin is itself a cluster, which could only be formed from minPoints points or more. So in case of origin cluster, we never reach this else case (numPoints will always be >= minPoints).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to set the minimum points required to form a cluster (
2by default).