-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic geometry #777
Generic geometry #777
Conversation
9513907
to
2d76836
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One note, otherwise 🚀
2d76836
to
5ff54bf
Compare
plugin-annotation/src/main/java/com/mapbox/mapboxsdk/plugins/annotation/Annotation.java
Outdated
Show resolved
Hide resolved
5ff54bf
to
b75a175
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
this.jsonObject = jsonObject; | ||
this.jsonObject.addProperty(ID_KEY, id); | ||
this.geometry = geometry; | ||
} | ||
|
||
void setGeometry(Geometry geometry) { | ||
public void setGeometry(T geometry) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are making set
/get
public, javadoc entry would be great.
b75a175
to
966f874
Compare
This PR uses generics to apply to correct geometry type for an annotation.