Deredeclare CLLocationManagerDelegate conformance on MGLMapView #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This SDK no longer makes use of the map SDK’s Core Location–dependent functionality, now that the user course view (user puck) is implemented entirely within the navigation SDK.
1ec5
added
op-ex
7 tasks
|
Can you confirm simulating locations still works? |
|
Yes, it still works as far as I can tell. Location simulation uses a location manager that’s built into Core Navigation. The map’s camera and user puck are both implemented within MapboxNavigation. If NavigationMapView or RouteMapViewController were to depend on MGLMapView’s conformance to CLLocationManagerDelegate somehow, these changes would’ve resulted in compiler errors, because Swift disallows sending undeclared messages to objects. |
…uide Also checked in the remaining image.
|
I’ve eviscerated that guide – the part about MGLMapView was never relevant to the guide in the first place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deredeclared MGLMapView’s conformance to the CLLocationManagerDelegate protocol. This SDK no longer makes use of the map SDK’s Core Location–dependent functionality, now that #402 has implemented the user course view (user puck) entirely within the navigation SDK. There is no developer or end-user impact to this change.
/cc @bsudekum @JThramer