This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
modify texture coordinate scaling #9153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
reviewed
May 31, 2017
|
@jfirebaugh yes sorry, that's what I meant by
so I didn't add the submodule bump yet bc the current gl-js commit breaks the tests because it includes has chris' text-pitch changes which are not yet incorporated into native it seems |
mollymerp
added
the
⚠️ DO NOT MERGE
10 tasks
5 tasks
mollymerp
force-pushed
the
texture-pos-scaling
branch
2 times, most recently
from
c4e5721
to
e7efc2a
Compare
mollymerp
force-pushed
the
texture-pos-scaling
branch
2 times, most recently
from
fc09695
to
0339534
Compare
|
😅 this is finally ready to 🎸 I think |
mollymerp
removed
the
⚠️ DO NOT MERGE
mollymerp
force-pushed
the
texture-pos-scaling
branch
5 times, most recently
from
af54b4c
to
f6d77e4
Compare
ignore unsupported dds property tests fix tests remove unneeded texture extent variable bump gl-js to master
mollymerp
force-pushed
the
texture-pos-scaling
branch
from
f6d77e4
to
70b7b62
Compare
kkaefer
approved these changes
Jul 27, 2017
|
@mollymerp Can you give me some suggestions about the following error: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponding PR to mapbox/mapbox-gl-js#4770
currently the commit in gl-js includes some breaking changes so I'll have to rebase against mapbox/mapbox-gl-js@ca1e1cf or wait til the text scaling work lands in native.